yuxiqian commented on code in PR #3804:
URL: https://github.com/apache/flink-cdc/pull/3804#discussion_r1890068874
##########
docs/content.zh/docs/core-concept/transform.md:
##########
@@ -39,10 +39,25 @@ To describe a transform rule, the following parameters can
be used:
| primary-keys | Sink table primary keys, separated by commas | optional
|
| partition-keys | Sink table partition keys, separated by commas |
optional |
| table-options | used to the configure table creation statement when
automatically creating tables | optional |
+| converter-after-transform | used to add a converter to change
DataChangeEvent after transform | optional |
| description | Transform rule description | optional |
Multiple rules can be declared in one single pipeline YAML file.
+## converter-after-transform
+
+`converter-after-transform` is used to change the DataChangeEvent after other
transform. The available values of this options are as follows.
+- SOFT_DELETE: The delete event will be converted as an insert event. This
converter should be used together with the metadata `__data_event_type__`. Then
you can implement the soft delete.
Review Comment:
Add a new line before Markdown list
##########
docs/content.zh/docs/core-concept/transform.md:
##########
@@ -39,10 +39,25 @@ To describe a transform rule, the following parameters can
be used:
| primary-keys | Sink table primary keys, separated by commas | optional
|
| partition-keys | Sink table partition keys, separated by commas |
optional |
| table-options | used to the configure table creation statement when
automatically creating tables | optional |
+| converter-after-transform | used to add a converter to change
DataChangeEvent after transform | optional |
| description | Transform rule description | optional |
Multiple rules can be declared in one single pipeline YAML file.
+## converter-after-transform
+
+`converter-after-transform` is used to change the DataChangeEvent after other
transform. The available values of this options are as follows.
+- SOFT_DELETE: The delete event will be converted as an insert event. This
converter should be used together with the metadata `__data_event_type__`. Then
you can implement the soft delete.
+
+For example, the following transform will not delete data when the delete
event happens. Instead it will update the column `op_type` to -D in sink when
deleting data.
Review Comment:
```suggestion
For example, the following transform will not delete data when the delete
event happens. Instead it will update the column `op_type` to -D in sink, and
transform it to an insert record.
```
##########
docs/content/docs/core-concept/transform.md:
##########
@@ -31,18 +31,33 @@ What's more, it also helps users filter some unnecessary
data during the synchro
# Parameters
To describe a transform rule, the following parameters can be used:
-| Parameter | Meaning |
Optional/Required |
-|--------------|----------------------------------------------------|-------------------|
-| source-table | Source table id, supports regular expressions | required
|
-| projection | Projection rule, supports syntax similar to the select clause
in SQL | optional |
-| filter | Filter rule, supports syntax similar to the where clause in
SQL | optional |
-| primary-keys | Sink table primary keys, separated by commas | optional
|
-| partition-keys | Sink table partition keys, separated by commas |
optional |
-| table-options | used to the configure table creation statement when
automatically creating tables | optional |
-| description | Transform rule description | optional |
+| Parameter | Meaning
| Optional/Required |
+|---------------------------|-----------------------------------------------------------------------------------|-------------------|
+| source-table | Source table id, supports regular expressions
| required |
+| projection | Projection rule, supports syntax similar to the
select clause in SQL | optional |
+| filter | Filter rule, supports syntax similar to the
where clause in SQL | optional |
+| primary-keys | Sink table primary keys, separated by commas
| optional |
+| partition-keys | Sink table partition keys, separated by commas
| optional |
+| table-options | used to the configure table creation statement
when automatically creating tables | optional |
+| converter-after-transform | used to add a converter to change
DataChangeEvent after transform | optional |
+| description | Transform rule description
| optional |
Multiple rules can be declared in one single pipeline YAML file.
+## converter-after-transform
+
+`converter-after-transform` is used to change the DataChangeEvent after other
transform. The available values of this options are as follows.
+- SOFT_DELETE: The delete event will be converted as an insert event. This
converter should be used together with the metadata `__data_event_type__`. Then
you can implement the soft delete.
Review Comment:
Ditto
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlE2eITCase.java:
##########
@@ -61,7 +61,8 @@ public class MysqlE2eITCase extends PipelineTestEnvironment {
public static final MySqlContainer MYSQL =
(MySqlContainer)
new MySqlContainer(
- MySqlVersion.V8_0) // v8 support both ARM
and AMD architectures
+ MySqlVersion
+ .V8_0_18) // v8 support both ARM
and AMD architectures
Review Comment:
Any reason using this specific version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
