snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1890409008


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -385,6 +388,18 @@ public static TimestampData toTimestampData(int v, int 
precision) {
         }
     }
 

Review Comment:
   if you move them to toTimestampLtzFunction you can encapsulate the logic 
like mentioned in a comment 
https://github.com/apache/flink/pull/25763#discussion_r1890023415



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to