davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1890522200
##########
flink-python/pyflink/table/table_environment.py:
##########
@@ -657,19 +657,55 @@ def drop_temporary_table(self, table_path: str) -> bool:
"""
return self._j_tenv.dropTemporaryTable(table_path)
+ def drop_table(self, table_path: str) -> bool:
+ """
+ Drops a table registered in the given path.
+
+ Temporary objects can shadow permanent ones.
+ If a permanent object in a given path exists,
+ it will be inaccessible in the current session.
+ To make the permanent object available again
+ one can drop the corresponding temporary object.
+
+ :param table_path: The path of the registered table.
+ :return: True if a table existed in the given path and was removed.
+
+ .. versionadded:: 2.0.0
+ """
+ return self._j_tenv.dropTable(table_path)
+
def drop_temporary_view(self, view_path: str) -> bool:
"""
Drops a temporary view registered in the given path.
If a permanent table or view with a given path exists, it will be used
from now on for any queries that reference this path.
+ :param view_path: The path of the registered temporary view.
:return: True if a view existed in the given path and was removed.
.. versionadded:: 1.10.0
"""
return self._j_tenv.dropTemporaryView(view_path)
+ def dropView(self, view_path: str) -> bool:
+ """
+
+ Drops a view registered in the given path.
+
+ Temporary objects can shadow permanent ones.
Review Comment:
Yes it is covered - I was looking to be specific and use the word view or
table where every we can for clarity - rather than use object. I think as it is
quite complicated - trying to be as explicit as possible would help the reader.
For example my assumptions are:
- dropView I assume only could drop a view, not a temporary view, a
connector table or temporary table. So using object is not very obvious.
- dropTable I assume dropTable means attempt to drop a table, and should
not be used against temporary objects.
(can dropTable be used against a view, as a view is a table or not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
