piotrp commented on code in PR #25813:
URL: https://github.com/apache/flink/pull/25813#discussion_r1890780745
##########
flink-core/src/main/java/org/apache/flink/util/MdcUtils.java:
##########
@@ -45,7 +45,13 @@ public class MdcUtils {
public static MdcCloseable withContext(Map<String, String> context) {
final Map<String, String> orig = MDC.getCopyOfContextMap();
MDC.setContextMap(context);
- return () -> MDC.setContextMap(orig);
+ return () -> {
Review Comment:
Oh, and this separate project would need to be removed when (if?) Flink
updates to SLF4J 2, because Logback 1.3.3 does accept
`MDC.setContextMap(null)`. Hence my question for desired direction, because I
don't want to write this test twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
