yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1883560697
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2332,14 +2332,24 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
public static final BuiltInFunctionDefinition TO_TIMESTAMP_LTZ =
BuiltInFunctionDefinition.newBuilder()
- .name("toTimestampLtz")
- .sqlName("TO_TIMESTAMP_LTZ")
+ .name("TO_TIMESTAMP_LTZ")
Review Comment:
Hi @snuyanzin , gave it a try and spent much time on it. Still, for some
reason, if I revert the two names back, when I run my new java tests, I got
errors like
`SQL validation failed. From line 1, column 8 to line 1, column 81: Cannot
apply 'TO_TIMESTAMP_LTZ' to arguments of type 'TO_TIMESTAMP_LTZ(<CHAR(25)>,
<CHAR(25)>)'. Supported form(s): 'TO_TIMESTAMP_LTZ(<NUMERIC>, <INTEGER>)'`
Could you shed some light on this? It seems like the SQL validation doesn't
pick up my change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
