snuyanzin commented on code in PR #25821:
URL: https://github.com/apache/flink/pull/25821#discussion_r1892524179


##########
flink-table/flink-table-api-scala/src/test/scala/org/apache/flink/table/types/extraction/DataTypeExtractorScalaTest.scala:
##########
@@ -37,8 +37,8 @@ class DataTypeExtractorScalaTest {
   def testScalaExtraction(testSpec: DataTypeExtractorTest.TestSpec): Unit = {
     if (testSpec.hasErrorMessage) {
       assertThatThrownBy(() => runExtraction(testSpec))
-        .isInstanceOf(classOf[ValidationException])
         .is(HamcrestCondition.matching(errorMatcher(testSpec)))
+        .isInstanceOf[ValidationException]

Review Comment:
   have you looked at PR description?
   it is written there
   >There is nothing wrong with current code if run it with maven
   
   >however scala's plugin of IntelliJIdea is not happy about it and constantly 
complaining if try to run scala tests from there (flink-table-planner module 
e.g TableEnvironmentTest)
   Also if just open this class in IntelliJIdea it will highlight the error in 
this place
   
   >I tried to ask JetBrains to fix it however still not done (after about 2 
years)
   
https://youtrack.jetbrains.com/issue/SCL-20679/Scala-plugin-becomes-broken-if-there-is-AssertJ-usage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to