twalthr commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1893677952
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##########
@@ -1040,6 +1066,32 @@ void createTemporarySystemFunction(
*/
boolean dropTemporaryView(String path);
+ /**
+ * Drops a view registered in the given path.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a temporary object
exists in a given path,
+ * make sure to drop the temporary object first using {@link
#dropTemporaryView}. This method
+ * can only drop permanent objects.
+ *
+ * <p>* Compared to SQL, this method will not throw an error if the table
does not exist. Use
Review Comment:
```suggestion
* <p>Compared to SQL, this method will not throw an error if the table
does not exist. Use
```
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##########
@@ -1040,6 +1066,32 @@ void createTemporarySystemFunction(
*/
boolean dropTemporaryView(String path);
+ /**
+ * Drops a view registered in the given path.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a temporary object
exists in a given path,
+ * make sure to drop the temporary object first using {@link
#dropTemporaryView}. This method
+ * can only drop permanent objects.
+ *
+ * <p>* Compared to SQL, this method will not throw an error if the table
does not exist. Use
+ * {@link #dropView(java.lang.String, boolean)} to change the default
behavior.
+ *
+ * @return true if a view existed in the given path and was removed
+ */
+ boolean dropView(String path);
+
+ /**
+ * Drops a view registered in the given path.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a temporary object
exists in a given path,
+ * make sure to drop the temporary object first using {@link
#dropTemporaryView}. This method
+ * can only drop permanent objects.
+ *
+ * @return true if a view existed in the given path and was removed Throws
{@link
+ * ValidationException} if view not exists and ignoreIfNotExists is
false
Review Comment:
```suggestion
* ValidationException} if the view does not exist and
ignoreIfNotExists is false
```
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##########
@@ -1040,6 +1066,32 @@ void createTemporarySystemFunction(
*/
boolean dropTemporaryView(String path);
+ /**
+ * Drops a view registered in the given path.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a temporary object
exists in a given path,
+ * make sure to drop the temporary object first using {@link
#dropTemporaryView}. This method
+ * can only drop permanent objects.
+ *
+ * <p>* Compared to SQL, this method will not throw an error if the table
does not exist. Use
+ * {@link #dropView(java.lang.String, boolean)} to change the default
behavior.
+ *
+ * @return true if a view existed in the given path and was removed
+ */
+ boolean dropView(String path);
+
+ /**
+ * Drops a view registered in the given path.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a temporary object
exists in a given path,
+ * make sure to drop the temporary object first using {@link
#dropTemporaryView}. This method
+ * can only drop permanent objects.
+ *
+ * @return true if a view existed in the given path and was removed Throws
{@link
Review Comment:
```suggestion
* @return true if a view existed in the given path and was removed,
throws {@link
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
