[
https://issues.apache.org/jira/browse/FLINK-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735510#comment-15735510
]
ASF GitHub Bot commented on FLINK-5113:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2939#discussion_r91721756
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamCheckpointNotifierITCase.java
---
@@ -447,5 +434,23 @@ public void notifyCheckpointComplete(long
checkpointId) {
GeneratingSourceFunction.numPostFailureNotifications.incrementAndGet();
}
}
+
+ @Override
+ public List<Long> snapshotState(long checkpointId, long
timestamp) throws Exception {
+ if (!hasFailed && count >= failurePos &&
getRuntimeContext().getIndexOfThisSubtask() == 0) {
--- End diff --
please move this methods up again to reduce the diff. The methods are
identical apart from the signature and return statement, the diff should
reflect that.
> Make all Testing Functions implement CheckpointedFunction Interface.
> --------------------------------------------------------------------
>
> Key: FLINK-5113
> URL: https://issues.apache.org/jira/browse/FLINK-5113
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Affects Versions: 1.2.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.2.0
>
>
> Currently stateful functions implement the (old) Checkpointed interface.
> This is issue aims at porting all these function to the new
> CheckpointedFunction interface, so that they can leverage the new
> capabilities by it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
