yiyutian1 commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1894521745
##########
flink-python/pyflink/table/tests/test_expression.py:
##########
@@ -299,6 +299,10 @@ def test_expressions(self):
lit(2).hours)))
self.assertEqual("dateFormat(time, '%Y, %d %M')",
str(date_format(col("time"), "%Y, %d %M")))
+ self.assertEqual("dateFormat(toTimestamp('1970-01-01 08:01:40'),
'yyyy-MM-dd HH:mm:ss')",
+ str(date_format(to_timestamp('1970-01-01 08:01:40'),
"yyyy-MM-dd HH:mm:ss")))
+ self.assertEqual("dateFormat('1970-01-01 08:01:40', 'yyyy-MM-dd
HH:mm:ss')",
Review Comment:
Hi @davidradl , sure I can add that.
Also want to point out that these test_expressions don't test any
implementations, they just test the "signature" of defined functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
