davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894874447
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -649,6 +649,13 @@ public boolean dropTemporaryTable(String path) {
}
}
+ @Override
+ public boolean dropTable(String path) {
+ UnresolvedIdentifier unresolvedIdentifier =
getParser().parseIdentifier(path);
+ ObjectIdentifier identifier =
catalogManager.qualifyIdentifier(unresolvedIdentifier);
+ return catalogManager.dropTable(identifier, true);
Review Comment:
sure. the code is `return catalogManager.dropTable(identifier, true);` but
should be
`return catalogManager.dropTable(identifier, ignoreIfNotExists);` otherwise
it does not pass the flag through
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
