pltbkd commented on code in PR #25797:
URL: https://github.com/apache/flink/pull/25797#discussion_r1897187206
##########
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java:
##########
@@ -356,6 +356,9 @@ public void configure(ReadableConfig configuration,
ClassLoader classLoader) {
configuration
.getOptional(PipelineOptions.FORCE_KRYO_AVRO)
.ifPresent(this::setForceKryoAvro);
+ configuration
+ .getOptional(PipelineOptions.BUILT_IN_COLLECTION_TYPES)
+ .ifPresent(TypeExtractor::setBuiltInCollectionTypesEnabled);
Review Comment:
The configuring approach seems problematic. As far as I know, the
TypeExtractor is a static util class shared in a TaskManager while the
SerializerConfig is scoped to the job level. This may lead to issues when
multiple jobs with different config values are submitted to the same cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
