yiyutian1 opened a new pull request, #25871:
URL: https://github.com/apache/flink/pull/25871

   What is the purpose of the change
   To update the documentation for DATE_FORMAT, which is not accurate now. The 
current function behaviors are:
   
   DATE_FORMAT(timestamp, string) eventually calls 
formatTimestamp(TimestampData ts, String format, ZoneId zoneId) in 
DateTimeUtils.java, which uses 
[DateTimeFormatter](https://issues.apache.org/jira/browse/FLINK-36941#L724).
   
   DATE_FORMAT(string, string) eventually calls 
formatTimestampStringWithOffset(String dateStr, String fromFormat, String 
toFormat, TimeZone tz, long offsetMills) in DateTimeUtils.java, which uses 
[SimpleDateFormat](https://github.com/apache/flink/blob/1523f2c2062b860a2abfe75f8ead276bb161d64a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java#L743).
   
   Brief change log
   Update documentation for DATE_FORMAT.
   Add additional python tests for specific DATE_FORMAT functions.
   Verifying this change
   Please make sure both new and modified tests in this PR follow [the 
conventions for tests defined in our code quality 
guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
   
   Added python tests for for specific DATE_FORMAT functions.
   
   Does this pull request potentially affect one of the following parts:
   Dependencies (does it add or upgrade a dependency): (no)
   The public API, i.e., is any changed class annotated with @Public(Evolving): 
(no)
   The serializers: (no)
   The runtime per-record code paths (performance sensitive): (no)
   Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
   The S3 file system connector: (no)
   Documentation
   Does this pull request introduce a new feature? (no)
   If yes, how is the feature documented? (not applicable)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to