yuxiqian commented on code in PR #3698:
URL: https://github.com/apache/flink-cdc/pull/3698#discussion_r1900740116
##########
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/parser/TransformParserTest.java:
##########
@@ -249,6 +249,8 @@ public void testTranslateFilterToJaninoExpression() {
"TO_DATE(dt, 'yyyy-MM-dd')", "toDate(dt, \"yyyy-MM-dd\",
__time_zone__)");
testFilterExpression("TO_TIMESTAMP(dt)", "toTimestamp(dt,
__time_zone__)");
testFilterExpression("TIMESTAMP_DIFF('DAY', dt1, dt2)",
"timestampDiff(\"DAY\", dt1, dt2)");
+ testFilterExpression("TIMESTAMPDIFF(DAY, dt1, dt2)",
"timestampdiff(\"DAY\", dt1, dt2)");
+ testFilterExpression("TIMESTAMPADD(DAY, 1, dt)",
"timestampadd(\"DAY\", 1, dt)");
Review Comment:
Also, why some functions require quoting timeUnits (like `'DAY'`) while some
doesn't? Any reasons behind this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
