Re: [PR] [FLINK-36070][flink-runtime-web] Modifying web UI to adapt to Incremental JobGraph Generation [flink]

Thu, 02 Jan 2025 04:26:05 -0800 


yuchen-ecnu commented on PR #25804:
URL: https://github.com/apache/flink/pull/25804#issuecomment-2567699492

   > Thanks, @yuchen-ecnu, for your contribution. I ran a WordCount job locally 
and tested the new web UI. I found that the checkbox `Show Pending Operators 
(Remaining: 0)` is always displayed regardless of whether there are any pending 
operators. I prefer not to display it if there are no pending operators. WDYT?
   > 
   > 1. No pending operators at the beginning.
   >    
![image](https://private-user-images.githubusercontent.com/107924572/399208517-52c66ad9-fd7d-4780-b5ba-41ad19ab2925.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzU4MTk5NzIsIm5iZiI6MTczNTgxOTY3MiwicGF0aCI6Ii8xMDc5MjQ1NzIvMzk5MjA4NTE3LTUyYzY2YWQ5LWZkN2QtNDc4MC1iNWJhLTQxYWQxOWFiMjkyNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwMlQxMjA3NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYjAxYzFkNmMzOWVlZjE2ODRkZmQzMzJhMTA3ZGNmMmQ2MDc5NzVmMzA0NTI0MjBlZTA4MzQ4ZWE0NjUzNzQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.F8RDLwi862jEZNTrxMLB7dT-J2miB0OB7ytYjOQ4C_w)
   > 2. All pending operators have been converted to job vertices.
   >    
![image](https://private-user-images.githubusercontent.com/107924572/399208567-53e0b3a9-4856-445c-97d8-44f36bdbf897.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzU4MTk5NzIsIm5iZiI6MTczNTgxOTY3MiwicGF0aCI6Ii8xMDc5MjQ1NzIvMzk5MjA4NTY3LTUzZTBiM2E5LTQ4NTYtNDQ1Yy05N2Q4LTQ0ZjM2YmRiZjg5Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwMlQxMjA3NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wYmUyM2ZlNjU4MDA1NTA2NTQ0OTkyZjRiNzU5OTM5NTkwYTY0YWY2MGU1MjVmMmE4MDM1NzJmMDA1MWU4YjViJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Eh1I18QQeZW1pxK1WA1TJG3l08hHvB5MGa4XIqwXm2o)
   
   Thanks @JunRuiLee , I updated the checkbox display condition to 
`[showPendingCheckbox]="pendingNodes.length > 0"`  to ensure it only appears in 
relevant cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to