hackergin commented on code in PR #25579:
URL: https://github.com/apache/flink/pull/25579#discussion_r1901441909


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogFactory.java:
##########
@@ -38,20 +37,7 @@
  * instead.
  */
 @PublicEvolving
-public interface CatalogFactory extends TableFactory, Factory {
-
-    /**
-     * Creates and configures a {@link Catalog} using the given properties.
-     *
-     * @param properties normalized properties describing an external catalog.
-     * @return the configured catalog.
-     * @deprecated Use {@link this#createCatalog(Context)} instead and 
implement {@link Factory}
-     *     instead of {@link TableFactory}.
-     */
-    @Deprecated
-    default Catalog createCatalog(String name, Map<String, String> properties) 
{

Review Comment:
   Since these methods already exist in the `Factory` interface, I directly 
removed them from `CatalogFactory`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to