xuyangzhong commented on code in PR #25326:
URL: https://github.com/apache/flink/pull/25326#discussion_r1901482689
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -253,18 +263,121 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
}
val types = fieldTypes.map(TypeConversions.fromLegacyInfoToDataType)
val names = FieldInfoUtils.getFieldNames(typeInfo)
- TableSchema.builder().fields(names, types).build()
+ TableSchema.builder().fields(names, types).build().toSchema
Review Comment:
To reduce the workload, I simply added a toSchema function. How about
postponing this work until removing TableSchema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
