hejufang commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2573083816
> Thanks for the PR! In general I have a question: why serializing the key/value by sampling, instead of read the serialization result/length of current put/add, especially for RocksDB? WDYT @masteryhx @Zakelly In my opinion, serializing the key/value by sampling has the following reasons: 1. Unlike state access latency, the size of key/value cannot be simply obtained in the outer MetricsTrackingState. For example, in RocksDBValueState#value valueBytes.length can only be accessed within the method 2. Serializing the key/value by sampling can also collect statistics on other types of statebackend, not only for RocksDB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
