yuxiqian commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1905026628
##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliFrontend.java:
##########
@@ -114,6 +122,22 @@ static CliExecutor createExecutor(CommandLine commandLine)
throws Exception {
savepointSettings);
}
+ private static void overrideFlinkConfiguration(
+ Configuration flinkConfig, CommandLine commandLine) {
+ Properties properties =
commandLine.getOptionProperties(FLINK_CONFIG.getOpt());
+ LOG.info("Dynamic flink config items found: {}", properties);
+ for (String key : properties.stringPropertyNames()) {
+ String value = properties.getProperty(key);
+ if (StringUtils.isNullOrWhitespaceOnly(key)
+ || StringUtils.isNullOrWhitespaceOnly(value)) {
+ throw new IllegalArgumentException("Illegal argument for key
or value");
Review Comment:
nit: maybe we can also print out the questionable key / value pair in
command line to improve exception traceability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
