dawidwys commented on code in PR #25907:
URL: https://github.com/apache/flink/pull/25907#discussion_r1905279516
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##########
@@ -1045,6 +1054,7 @@ public void createTable(
objectIdentifier,
false,
"CreateTable");
+ return result;
Review Comment:
I think this will rarely return. In most cases `TableAlreadyExistException`
will be thrown :(
I believe without changing the signature of `Catalog#createTable` to also
return `boolean` it is not possible to properly handle the boolean return
value. What is the intention to change the return type? I am fine proceeding
with the change as suggested, but I don't see it being an improvement to the
current state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
