dyccode commented on code in PR #25711:
URL: https://github.com/apache/flink/pull/25711#discussion_r1905391448
##########
flink-formats/flink-orc/pom.xml:
##########
@@ -141,6 +149,34 @@ under the License.
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>${protoc.version}</version>
+ <scope>provided</scope>
Review Comment:
@MartijnVisser I'm sorry, I've been quite busy lately and I'm only replying
now.
1. I updated the scope of the related maven dependencies.
2. I tested upgrading Flink 1.20 to Flink 2.0:
a. I started a Flink program with a data source that generates random
data. The program performs deduplication based on keys using RocksDB for state
storage, and the deduplicated data is written to HDFS in ORC format. The Flink
version used is 1.20.
b. After running for a while, the program was stopped using a savepoint.
c. I restarted the program using Flink 2.0 and the savepoint. The program
ran successfully, and the generated ORC files were also correct.
3. **In ORC version 1.9.4, the field names of the table must match the field
names in the ORC file schema.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
