yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1905915205
##########
flink-python/pyflink/table/tests/test_expression.py:
##########
@@ -285,7 +285,14 @@ def test_expressions(self):
self.assertEqual("toDate('2018-03-18')", str(to_date('2018-03-18')))
self.assertEqual("toDate('2018-03-18', 'yyyy-MM-dd')",
str(to_date('2018-03-18', 'yyyy-MM-dd')))
- self.assertEqual('toTimestampLtz(123, 0)', str(to_timestamp_ltz(123,
0)))
Review Comment:
Hi @davidradl , I checked those negatives cases in Java tests. To reduce the
python overhead in Flink, we usually don't duplicate tests in python tests.
Also, Flink tests are very light-weight, and only check function
**signatures**, not the function themselves. In other words, even a negative
test won't return error here. If we add one here, it might lead to some
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
