huwh commented on code in PR #25915:
URL: https://github.com/apache/flink/pull/25915#discussion_r1906862063
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java:
##########
@@ -1203,12 +1203,17 @@ void
cancelOrFailAndCancelInvokableInternal(ExecutionState targetState, Throwabl
return;
}
- if (current == ExecutionState.DEPLOYING || current ==
ExecutionState.CREATED) {
+ if (current == ExecutionState.CREATED) {
if (transitionState(current, targetState, cause)) {
// if we manage this state transition, then the invokable
gets never called
// we need not call cancel on it
return;
}
+ } else if (current == ExecutionState.DEPLOYING) {
+ if (transitionState(current, targetState, cause)) {
Review Comment:
It's better to add some comments:
Tasks may hang on the Invokable constructor or static code. We need add a
watchdog to ensure the task does not remain hanging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
