zhuzhurk commented on code in PR #25822:
URL: https://github.com/apache/flink/pull/25822#discussion_r1907059582
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/DefaultStreamGraphContext.java:
##########
@@ -140,6 +152,33 @@ public boolean
modifyStreamEdge(List<StreamEdgeUpdateRequestInfo> requestInfos)
if (newPartitioner != null) {
modifyOutputPartitioner(targetEdge, newPartitioner);
}
+ if (targetEdge != null && requestInfo.getTypeNumber() != 0) {
Review Comment:
If it's not expected and only happens if there is a bug, it's better to
simply `checkNotNull` and expose problems instead of cover it.
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/DefaultStreamGraphContext.java:
##########
@@ -140,6 +152,33 @@ public boolean
modifyStreamEdge(List<StreamEdgeUpdateRequestInfo> requestInfos)
if (newPartitioner != null) {
modifyOutputPartitioner(targetEdge, newPartitioner);
}
+ if (targetEdge != null && requestInfo.getTypeNumber() != 0) {
Review Comment:
If it's not expected and only happens if there is a bug, it's better to
simply `checkNotNull` to expose problems instead of cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
