leonardBang commented on code in PR #3841:
URL: https://github.com/apache/flink-cdc/pull/3841#discussion_r1907093756
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/splitter/JdbcSourceChunkSplitter.java:
##########
@@ -261,12 +261,16 @@ protected Column getSplitColumn(Table table, @Nullable
String chunkKeyColumn) {
}
/** ChunkEnd less than or equal to max. */
- protected boolean isChunkEndLeMax(Object chunkEnd, Object max, Column
splitColumn) {
+ protected boolean isChunkEndLeMax(
+ JdbcConnection jdbc, Object chunkEnd, Object max, Column
splitColumn)
Review Comment:
Here we'd better to annotate `@Nullable JdbcConnection jdbc` for some
dialect they do not need connection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
