Jzjsnow commented on code in PR #3838:
URL: https://github.com/apache/flink-cdc/pull/3838#discussion_r1908069490
##########
flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh:
##########
@@ -21,9 +21,20 @@ args=("$@")
# Check if FLINK_HOME is set in command-line arguments by "--flink-home"
for ((i=0; i < ${#args[@]}; i++)); do
case "${args[i]}" in
+ --flink-home=*)
+ # Extract the value after "="
+ FLINK_HOME_VALUE="${args[i]#*=}"
+ # Check if the value is not empty
+ if [[ -n "$FLINK_HOME_VALUE" ]]; then
+ FLINK_HOME="$FLINK_HOME_VALUE"
+ echo "set FLINK_HOME to ${FLINK_HOME_VALUE}"
Review Comment:
Thanks for the suggestion, I also capitalized the initials for consistency
in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]