xuyangzhong commented on code in PR #25680:
URL: https://github.com/apache/flink/pull/25680#discussion_r1908323169
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala:
##########
@@ -397,17 +450,19 @@ class GroupAggregateHarnessTest(mode: StateBackendMode,
miniBatch: MiniBatchMode
// expect no exception happens
testHarness.close()
}
+
}
object GroupAggregateHarnessTest {
- @Parameters(name = "StateBackend={0}, MiniBatch={1}")
+ @Parameters(name = "StateBackend={0}, MiniBatch={1}, EnableAsyncState={2}")
def parameters(): JCollection[Array[java.lang.Object]] = {
Seq[Array[AnyRef]](
- Array(HEAP_BACKEND, MiniBatchOff),
- Array(HEAP_BACKEND, MiniBatchOn),
- Array(ROCKSDB_BACKEND, MiniBatchOff),
- Array(ROCKSDB_BACKEND, MiniBatchOn)
+ Array(HEAP_BACKEND, MiniBatchOff, Boolean.box(false)),
+ Array(HEAP_BACKEND, MiniBatchOff, Boolean.box(true)),
+ Array(HEAP_BACKEND, MiniBatchOn, Boolean.box(false)),
+ Array(ROCKSDB_BACKEND, MiniBatchOff, Boolean.box(false)),
+ Array(ROCKSDB_BACKEND, MiniBatchOn, Boolean.box(false))
Review Comment:
Yes, a separate jira is already tracking this task:
https://issues.apache.org/jira/browse/FLINK-36354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
