davidradl commented on code in PR #25826:
URL: https://github.com/apache/flink/pull/25826#discussion_r1908842415
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala:
##########
@@ -176,13 +176,16 @@ object FlinkBatchRuleSets {
/** RuleSet to prune empty results rules */
val PRUNE_EMPTY_RULES: RuleSet = RuleSets.ofList(
- PruneEmptyRules.AGGREGATE_INSTANCE,
+ PruneEmptyRules.UNION_INSTANCE,
+ PruneEmptyRules.INTERSECT_INSTANCE,
+ PruneEmptyRules.MINUS_INSTANCE,
+ PruneEmptyRules.PROJECT_INSTANCE,
PruneEmptyRules.FILTER_INSTANCE,
+ PruneEmptyRules.SORT_INSTANCE,
Review Comment:
I wonder is there a way to put these rules in Java rather than Scala - as I
believe the direction is to remove Scala from the table planner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
