yuxiqian commented on code in PR #3836:
URL: https://github.com/apache/flink-cdc/pull/3836#discussion_r1910216599
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PreTransformProcessor.java:
##########
@@ -62,30 +62,18 @@ public CreateTableEvent
preTransformCreateTableEvent(CreateTableEvent createTabl
public BinaryRecordData processFillDataField(BinaryRecordData data) {
List<Object> valueList = new ArrayList<>();
List<Column> columns =
tableChangeInfo.getPreTransformedSchema().getColumns();
- for (int i = 0; i < columns.size(); i++) {
- valueList.add(
- getValueFromBinaryRecordData(
- columns.get(i).getName(),
- data,
- tableChangeInfo.getSourceSchema().getColumns(),
- tableChangeInfo.getSourceFieldGetters()));
+ Map<String, RecordData.FieldGetter> sourceFieldGetters =
+ tableChangeInfo.getSourceFieldGetters();
+ for (Column column : columns) {
+ RecordData.FieldGetter fieldGetter =
sourceFieldGetters.get(column.getName());
+ if (fieldGetter != null) {
Review Comment:
I think `TableChangeInfo` should be able to guarantee the invariability that
for each column in `preTransformedSchema`, there must be corresponding
`fieldGetters` available.
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PreTransformChangeInfo.java:
##########
@@ -59,7 +61,11 @@ public PreTransformChangeInfo(
this.tableId = tableId;
this.sourceSchema = sourceSchema;
this.preTransformedSchema = preTransformedSchema;
- this.sourceFieldGetters = sourceFieldGetters;
+ this.sourceFieldGetters = new HashMap<>(sourceSchema.getColumnCount());
+ for (int i = 0; i < sourceSchema.getColumns().size(); i++) {
+ this.sourceFieldGetters.put(
+ sourceSchema.getColumns().get(i).getName(),
sourceFieldGetters[i]);
+ }
Review Comment:
Maybe `this.sourceFieldGetters` -> `this.sourceFieldGettersMap`, as now it
has different type and meaning with the constructor parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
