davidradl commented on code in PR #25948:
URL: https://github.com/apache/flink/pull/25948#discussion_r1910227028
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/factories/TableFactoryUtil.java:
##########
@@ -70,28 +66,14 @@ public static <T> TableSource<T>
findAndCreateTableSource(TableSourceFactory.Con
*/
@SuppressWarnings("unchecked")
public static <T> TableSource<T> findAndCreateTableSource(
- @Nullable Catalog catalog,
ObjectIdentifier objectIdentifier,
CatalogTable catalogTable,
ReadableConfig configuration,
boolean isTemporary) {
TableSourceFactory.Context context =
new TableSourceFactoryContextImpl(
objectIdentifier, catalogTable, configuration,
isTemporary);
- Optional<TableFactory> factoryOptional =
- catalog == null ? Optional.empty() : catalog.getTableFactory();
Review Comment:
A question: why is it safe to delete this call rather than using
getFactory() as per the deprecation comments in getTableFactory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
