linghengqian commented on code in PR #136: URL: https://github.com/apache/flink-connector-jdbc/pull/136#discussion_r1910444296
########## flink-connector-jdbc-elasticsearch/pom.xml: ########## @@ -0,0 +1,122 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-jdbc-parent</artifactId> + <version>3.3-SNAPSHOT</version> + </parent> + + <artifactId>flink-connector-jdbc-elasticsearch</artifactId> + <name>Flink : Connectors : JDBC : Elasticsearch</name> + + <packaging>jar</packaging> + + <properties> + <elasticsearch.version>8.14.3</elasticsearch.version> + <jackson-databind.version>2.13.4.2</jackson-databind.version> + <jackson-datatype-jsr310.version>2.13.4</jackson-datatype-jsr310.version> + </properties> + + <dependencies> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-jdbc-core</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-jdbc-core</artifactId> + <version>${project.version}</version> + <type>test-jar</type> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-api-java-bridge</artifactId> + <version>${flink.version}</version> + <scope>provided</scope> + <optional>true</optional> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-planner_${scala.binary.version}</artifactId> + <version>${flink.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-planner_${scala.binary.version}</artifactId> + <version>${flink.version}</version> + <type>test-jar</type> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-test-utils</artifactId> + <version>${flink.version}</version> + <scope>test</scope> + </dependency> + + + <!-- Elasticsearch --> + <dependency> + <groupId>org.elasticsearch.plugin</groupId> + <artifactId>x-pack-sql-jdbc</artifactId> + <version>${elasticsearch.version}</version> + <scope>provided</scope> + </dependency> Review Comment: - According to https://discuss.elastic.co/t/the-documentation-does-not-seem-to-document-the-minimum-jdk-runtime-requirement-for-org-elasticsearch-plugin-x-pack-sql-jdbc/372078/3?u=linghengqian and https://github.com/elastic/elasticsearch/issues/119924 , the committer of ElasticSearch pointed out that `org.elasticsearch.plugin:x-pack-sql-jdbc` is mainly used inside ElasticSearch. It is not suitable for scenarios including Flink. > I don't understand. The plugin runs inside Elasticsearch so it uses the JVM provided by Elasticsearch. > It's not meant to be reused anywhere else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
