gyfora commented on code in PR #930:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/930#discussion_r1910525502
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/JobTopology.java:
##########
@@ -150,6 +151,11 @@ public static JobTopology fromJsonPlan(
ObjectNode plan = objectMapper.readValue(jsonPlan, ObjectNode.class);
ArrayNode nodes = (ArrayNode) plan.get("nodes");
+ if (nodes == null || nodes.isEmpty()) {
+ throw new NotReadyException(
+ new RuntimeException("No nodes found in the plan, job is
not ready yet"));
Review Comment:
Can we maybe add a new constructor to the `NotReadyException` so we don't
need to wrap an unnecessary RuntimeException?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
