snuyanzin commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1911963506
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##########
@@ -616,23 +616,23 @@ private Stream<TestSetSpec> ceilTestCases() {
.ceil(TimeIntervalUnit.MILLISECOND)
.cast(STRING()),
"CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(9)) TO
MILLISECOND) AS STRING)",
- LocalDateTime.of(2021, 9, 24, 9, 20, 50,
925_000_000)
+ LocalDateTime.of(2021, 9, 24, 9, 20, 51, 0)
.format(TIMESTAMP_FORMATTER),
STRING().nullable())
.testResult(
$("f3").cast(TIMESTAMP_LTZ(9))
.ceil(TimeIntervalUnit.MICROSECOND)
.cast(STRING()),
"CAST(CEIL(CAST(f3 AS TIMESTAMP_LTZ(9)) TO
MICROSECOND) AS STRING)",
- LocalDateTime.of(2021, 9, 24, 9, 20, 50,
924_326_000)
Review Comment:
we shouldn't remove this test
otherwise how can we distinguish the behavior from the one which just always
truncates nanos and increments millis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
