ryanvanhuuksloot commented on code in PR #25899:
URL: https://github.com/apache/flink/pull/25899#discussion_r1913881644
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SnapshotType.java:
##########
@@ -25,6 +25,8 @@ public interface SnapshotType extends Serializable {
boolean isSavepoint();
+ boolean isIncrementalCheckpoint();
Review Comment:
>It's good to name this isFull or isIncremental for internal APIs. What I
meant in the email is that the REST API should has incremental or
is_incremental for input or output, which is user-facing. To simplify, I
suggest name this isFull().
👍
>And the default implementation would be getSharingFilesStrategy() !=
FORWARD_BACKWARD for isFull(). It is good for maintain as you won't change this
part when adding another instance other than FULL_CHECKPOINT. WDYT?
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
