snuyanzin commented on code in PR #25972:
URL: https://github.com/apache/flink/pull/25972#discussion_r1914428769
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/bridging/BridgingSqlFunction.java:
##########
@@ -279,5 +279,15 @@ public SqlReturnTypeInference getRowTypeInference() {
}
return TableCharacteristic.builder(semantics).build();
}
+
+ @Override
+ public boolean argumentMustBeScalar(int ordinal) {
+ final List<StaticArgument> args =
typeInference.getStaticArguments().orElse(null);
+ if (args == null || ordinal >= args.size()) {
+ return true;
+ }
+ final StaticArgument arg = args.get(ordinal);
+ return !arg.is(StaticArgumentTrait.TABLE);
Review Comment:
should here be explicit check for scalar?
I'm asking since not sure that every non-`TABLE` fits here from
https://github.com/apache/flink/blob/1adcf1e47a7e6ae9908736c3969e2d279a44bc18/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StaticArgumentTrait.java#L35-L40
\+ in theory adding a new value could unintentionally break something in
future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
