ChaomingZhangCN commented on code in PR #3859:
URL: https://github.com/apache/flink-cdc/pull/3859#discussion_r1916398687
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/common/SchemaRegistry.java:
##########
@@ -280,7 +280,9 @@ public final void subtaskReset(int subTaskId, long
checkpointId) {
@Override
public final void executionAttemptFailed(
int subTaskId, int attemptNumber, @Nullable Throwable reason) {
- failedReasons.put(subTaskId, reason);
+ if (reason != null) {
+ failedReasons.put(subTaskId, reason);
+ }
Review Comment:
Can not put a null value into ConcurrentHashMap, which will cause NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]