[
https://issues.apache.org/jira/browse/FLINK-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742957#comment-15742957
]
ASF GitHub Bot commented on FLINK-5113:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2939
It should be part of this PR since this case simply didn't exist before the
new interface. The equivalent to no state was the state being null, at which
point restore was never called in the first place. Now, if the state is null we
get an empty list, afaik.
Here is what is confusing me: Every single function checks whether the
state is empty. Every one. So, there is apparently the possibility that it's
empty. But the behavior for that case does not seem well-defined.
According to the code receiving an empty state list is not a reason to fail
for any of these tests.
If this is the case we don't need to actually implement `restoreState` in
the first place since it is irrelevant to the result of the test
If this is not the case we should try to fail as early as possible by
adding a failure condition.
> Make all Testing Functions implement CheckpointedFunction Interface.
> --------------------------------------------------------------------
>
> Key: FLINK-5113
> URL: https://issues.apache.org/jira/browse/FLINK-5113
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Affects Versions: 1.2.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.2.0
>
>
> Currently stateful functions implement the (old) Checkpointed interface.
> This is issue aims at porting all these function to the new
> CheckpointedFunction interface, so that they can leverage the new
> capabilities by it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
