ryanvanhuuksloot commented on code in PR #25899:
URL: https://github.com/apache/flink/pull/25899#discussion_r1918894401
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointProperties.java:
##########
@@ -283,6 +293,39 @@ public String toString() {
false, // Retain on suspension
false);
+ private static final CheckpointProperties FULL_CHECKPOINT_NEVER_RETAINED =
+ new CheckpointProperties(
+ false,
+ CheckpointType.FULL_CHECKPOINT,
+ true,
+ true, // Delete on success
+ true, // Delete on cancellation
+ true, // Delete on failure
+ true, // Delete on suspension
+ false);
+
+ private static final CheckpointProperties
FULL_CHECKPOINT_RETAINED_ON_FAILURE =
+ new CheckpointProperties(
+ false,
+ CheckpointType.FULL_CHECKPOINT,
+ true,
+ true, // Delete on success
+ true, // Delete on cancellation
+ false, // Retain on failure
+ true, // Delete on suspension
+ false);
+
+ private static final CheckpointProperties
FULL_CHECKPOINT_RETAINED_ON_CANCELLATION =
+ new CheckpointProperties(
+ false,
+ CheckpointType.FULL_CHECKPOINT,
+ true,
+ true, // Delete on success
+ false, // Retain on cancellation
+ false, // Retain on failure
+ false, // Retain on suspension
+ false);
+
Review Comment:
I agree looking at the `CheckpointCoordinator`.
https://github.com/apache/flink/blob/55de8d683cc56733c03c11f927f511b2ba712851/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L355-L356
Specifically, the issue is that `Checkpoint` can be used for both full or
incremental.
https://github.com/apache/flink/blob/55de8d683cc56733c03c11f927f511b2ba712851/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointType.java#L29-L31
We'd have to move the evaluation of `execution.checkpointing.incremental` or
change how we are determining if a Checkpoint is Full 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
