yuxiqian commented on code in PR #3869:
URL: https://github.com/apache/flink-cdc/pull/3869#discussion_r1919395001
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java:
##########
@@ -1076,6 +1077,75 @@ public void testIncludeComments() throws Exception {
actual.stream().map(Object::toString).collect(Collectors.toList()));
}
+ @Test
+ public void testIncludeCommentsForScanBinlogNewlyAddedTableEnabled()
throws Exception {
+ env.setParallelism(1);
+ inventoryDatabase.createAndInitialize();
+ TableId tableId = TableId.tableId(inventoryDatabase.getDatabaseName(),
"products");
+ TableId newTableId =
+ TableId.tableId(inventoryDatabase.getDatabaseName(),
"products_with_comments2");
+
+ Map<String, String> options = new HashMap<>();
+ options.put(HOSTNAME.key(), MYSQL8_CONTAINER.getHost());
+ options.put(PORT.key(),
String.valueOf(MYSQL8_CONTAINER.getDatabasePort()));
+ options.put(USERNAME.key(), TEST_USER);
+ options.put(PASSWORD.key(), TEST_PASSWORD);
+ options.put(SERVER_TIME_ZONE.key(), "UTC");
+ options.put(INCLUDE_COMMENTS_ENABLED.key(), "true");
+ options.put(SCAN_BINLOG_NEWLY_ADDED_TABLE_ENABLED.key(), "true");
+ options.put(TABLES.key(), inventoryDatabase.getDatabaseName() +
".products\\.*");
+ Factory.Context context =
+ new FactoryHelper.DefaultContext(
+ Configuration.fromMap(options), null,
this.getClass().getClassLoader());
+
+ MySqlDataSourceFactory factory = new MySqlDataSourceFactory();
+ MySqlDataSource dataSource = (MySqlDataSource)
factory.createDataSource(context);
+ FlinkSourceProvider sourceProvider =
+ (FlinkSourceProvider) dataSource.getEventSourceProvider();
+
+ CloseableIterator<Event> events =
+ env.fromSource(
+ sourceProvider.getSource(),
+ WatermarkStrategy.noWatermarks(),
+ MySqlDataSourceFactory.IDENTIFIER,
+ new EventTypeInfo())
+ .executeAndCollect();
+ Thread.sleep(5_000);
Review Comment:
nit: we can `fetchResults` here to ensure snapshot stage to be over before
generating binlog events, instead of sleeping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
