showuon commented on code in PR #26003:
URL: https://github.com/apache/flink/pull/26003#discussion_r1919873880
##########
flink-runtime/src/test/java/org/apache/flink/runtime/memory/MemoryManagerConcurrentModReleaseTest.java:
##########
@@ -97,6 +101,12 @@ public void run() {
try {
MemorySegment seg = toModify.remove(0);
toModify.add(seg);
+ // if the test running time reaches TEST_TIMEOUT_MS, we
should lower the
+ // priority of the Modifier thread to let segment release
completes sooner.
Review Comment:
@davidradl , thanks for the comment. I agree `yield` depends on the OS
implementation. I changed to `sleep(1)` to force yield the CPU resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
