Zakelly commented on code in PR #26000:
URL: https://github.com/apache/flink/pull/26000#discussion_r1919924924


##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/transformations/OneInputTransformation.java:
##########
@@ -185,6 +185,9 @@ public final void setChainingStrategy(ChainingStrategy 
strategy) {
         operatorFactory.setChainingStrategy(strategy);
     }
 
+    @Override
+    public void enableAsyncState() {}

Review Comment:
   ```suggestion
       public void enableAsyncState() {
               OneInputStreamOperator<IN, OUT> operator = 
(OneInputStreamOperator<IN, OUT>)
                   ((SimpleOperatorFactory<OUT>) operatorFactory).getOperator();
               if (!(operator instanceof AsyncStateProcessingOperator)) {
                   super.enableAsyncState();
               }
       }
   ```



##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/sync/ForStSyncKeyedStateBackend.java:
##########
@@ -602,7 +602,7 @@ public RunnableFuture<SnapshotResult<KeyedStateHandle>> 
snapshot(
     @Nonnull
     @Override
     public SavepointResources<K> savepoint() throws Exception {
-        throw new UnsupportedOperationException("This method is not 
supported.");
+        throw new UnsupportedOperationException("Savepoint is not supported by 
forst now.");

Review Comment:
   ```suggestion
           throw new UnsupportedOperationException("Canonical savepoints are 
not supported by ForSt State Backend.");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to