dianfu commented on code in PR #26011:
URL: https://github.com/apache/flink/pull/26011#discussion_r1921819843
##########
flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/process/timer/TimerRegistrationAction.java:
##########
@@ -26,17 +29,33 @@ public class TimerRegistrationAction {
private boolean isRegistered;
+ private final List<TimerRegistrationAction> containingList;
+
public TimerRegistrationAction(
- TimerRegistration timerRegistration, byte[] serializedTimerData) {
+ TimerRegistration timerRegistration,
+ byte[] serializedTimerData,
+ List<TimerRegistrationAction> containingList) {
this.timerRegistration = timerRegistration;
this.serializedTimerData = serializedTimerData;
+ this.containingList = containingList;
this.isRegistered = false;
}
public void run() {
+ registerTimer();
+ cleanup();
Review Comment:
What about merging registerTimer and cleanup together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
