JunRuiLee commented on code in PR #26025:
URL: https://github.com/apache/flink/pull/26025#discussion_r1923081150
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PartitionedFileWriteReadTest.java:
##########
@@ -755,7 +762,7 @@ private PartitionedFileWriter createPartitionedFileWriter(
private PartitionedFileWriter createAndFinishPartitionedFileWriter()
throws IOException {
PartitionedFileWriter partitionedFileWriter =
createPartitionedFileWriter(1, new int[0]);
- partitionedFileWriter.finish();
+ partitionedFileWriter.finish().deleteQuietly();
Review Comment:
I think we should delete the partitioned file after the test finishes
instead of at the beginning. How about make this change at the end of
`testFinishPartitionedFileWriterTwice()` and
`testWriteFinishedPartitionedFile()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]