[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745638#comment-15745638
]
ASF GitHub Bot commented on FLINK-4704:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2958
Thanks for the PR @ex00!
I would like to suggest to move a few more files:
- move `flink-table` examples: `org/apache/flink/examples` ->
`org/apache/flink/table/examples` (for Java and Scala)
- move `src/main/scala/org/apache/flink/table/windows.scala` ->
`src/main/scala/org/apache/flink/table/api/windows.scala`
- move `src/main/scala/org/apache/flink/table/Types.scala` ->
`src/main/scala/org/apache/flink/table/typeutils/Types.scala`
- move `src/main/scala/org/apache/flink/table/trees/TreeNode.scala` ->
`src/main/scala/org/apache/flink/table/plan/TreeNode.scala` and remove the
empty `trees` package / folder
- create a new package `org.apache.flink.table.calcite` and move
`CalciteConfig.scala`, `FlinkCalciteSqlValidator.scala`,
`FlinkPlannerImpl.scala`, `FlinkRelBuilder.scala`, `FlinkTypeFactory.scala`,
and `FlinkTypeSystem.scala` from `src/main/scala/org/apache/flink/table` to
`src/main/scala/org/apache/flink/table/calcite`
What do you think @ex00 and @twalthr?
> Move Table API to org.apache.flink.table
> ----------------------------------------
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Anton Mushin
> Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
