davidradl commented on code in PR #26008:
URL: https://github.com/apache/flink/pull/26008#discussion_r1928944185
##########
flink-python/setup.py:
##########
@@ -318,7 +318,7 @@ def extracted_output_files(base_dir, file_path,
output_directory):
install_requires = ['py4j==0.10.9.7', 'python-dateutil>=2.8.0,<3',
'apache-beam>=2.54.0,<=2.61.0',
- 'cloudpickle>=2.2.0', 'avro-python3>=1.8.1,!=1.9.2',
+ 'cloudpickle>=2.2.0', 'avro>=1.12.0',
Review Comment:
There seems to be slight differences between the old avro-python3 and the
new preferred avro packages. I assume the other changes in this pr relate to
the slight changes. The original code seems to be tolerating a range of
versions, do we know why? Or is the latest fine?
I am curious whether fastavro needs to be updated to be compatible with avro
1.12.0 in any way. fastavro 1.1 is 5 years old - should we push this to the
latest as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
