davidradl commented on code in PR #26084:
URL: https://github.com/apache/flink/pull/26084#discussion_r1930448042
##########
flink-core/src/main/java/org/apache/flink/api/connector/source/util/ratelimit/RateLimiterStrategy.java:
##########
@@ -42,9 +43,14 @@ public interface RateLimiterStrategy extends Serializable {
* @param recordsPerSecond The number of records produced per second. The
actual number of
* produced records is subject to rounding due to dividing the number
of produced records
* among the parallel instances.
+ * @deprecated Use {@link PerSecondRateLimiterStrategy#create(double,
Duration)}, instead, to
+ * avoid thread leakage.
*/
+ @Deprecated
static RateLimiterStrategy perSecond(double recordsPerSecond) {
- return parallelism -> new GuavaRateLimiter(recordsPerSecond /
parallelism);
Review Comment:
Should we not deprecate GuavaRateLimiter.java rather then delete it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
