ferenc-csaky commented on code in PR #55:
URL:
https://github.com/apache/flink-connector-hbase/pull/55#discussion_r1932468530
##########
flink-sql-connector-hbase-2.2/pom.xml:
##########
@@ -144,6 +144,8 @@ under the License.
KeyValueCodec class when decode the data, so we exclude them here. -->
<excludes>
<exclude>org.apache.hadoop.hbase.codec.*</exclude>
+
<exclude>org/apache/hadoop/hbase/NotServingRegionException</exclude>
+
<exclude>org/apache/hadoop/hbase/exceptions/RegionMovedException</exclude>
Review Comment:
Can we pls. replace `/` to `.` to keep this section consistent? It works
that way the same as well.
##########
flink-sql-connector-hbase-2.2/pom.xml:
##########
Review Comment:
Can we extend the comment starting @ L142 with something like:
> Some exceptions also required to keep their original package because the
region
> server sends it that way, and it is required for proper handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
