snuyanzin commented on code in PR #25834:
URL: https://github.com/apache/flink/pull/25834#discussion_r1933535365
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java:
##########
@@ -324,6 +338,8 @@ private static Optional<Operation> convertValidatedSqlNode(
return
Optional.of(converter.convertShowCreateView((SqlShowCreateView) validated));
} else if (validated instanceof SqlRichExplain) {
return Optional.of(converter.convertRichExplain((SqlRichExplain)
validated));
+ } else if (validated instanceof SqlRichDescribeModel) {
+ return
Optional.of(converter.convertDescribeModel((SqlRichDescribeModel) validated));
Review Comment:
Is there anything that blocks from moving it to SqlNodeConverters instead
of putting here?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java:
##########
@@ -365,6 +381,11 @@ private static Optional<Operation> convertValidatedSqlNode(
return Optional.of(converter.convertDelete((SqlDelete) validated));
} else if (validated instanceof SqlUpdate) {
return Optional.of(converter.convertUpdate((SqlUpdate) validated));
+ } else if (validated instanceof SqlAlterModel) {
+ return Optional.of(
+
converter.alterModelConverter.convertAlterModel((SqlAlterModel) validated));
+ } else if (validated instanceof SqlDropModel) {
+ return Optional.of(converter.convertDropModel((SqlDropModel)
validated));
Review Comment:
Is there anything that blocks from moving it to SqlNodeConverters instead
of putting here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
