snuyanzin commented on code in PR #26091:
URL: https://github.com/apache/flink/pull/26091#discussion_r1936106302
##########
docs/data/sql_functions.yml:
##########
@@ -431,10 +435,10 @@ string:
- sql: TRANSLATE(expr, fromStr, toStr)
table: expr.translate(fromStr, toStr)
description: |
- Translate an expr where all characters in fromStr have been replaced
with those in toStr.
-
- If toStr has a shorter length than fromStr, unmatched characters are
removed.
+ Translate an expr where all characters in fromStr have been replaced
with those in toStr. If toStr has a shorter length than fromStr, unmatched
characters are removed.
+ E.g., SELECT TRANSLATE3('www.apache.org', 'wapcheorg', ' APCHEcom') or
'www.apache.org'.translate('wapcheorg', ' APCHEcom') returns " .APACHE.com".
+
Review Comment:
nit
```suggestion
E.g., SELECT TRANSLATE3('www.apache.org', 'wapcheorg', ' APCHEcom') or
'www.apache.org'.translate('wapcheorg', ' APCHEcom') returns ' .APACHE.com'.
```
in SQL string usually should be quoted with single quotes
same for chinese doc
##########
docs/data/sql_functions.yml:
##########
@@ -531,6 +535,8 @@ string:
description: |
Returns the index-th expression. index must be an integer between 1 and
the number of expressions.
+ E.g., SELECT ELT(2, 'scala-1', 'java-2', 'go-3') or 2.elt('scala-1',
'java-2', 'go-3') returns "java-2".
+
Review Comment:
```suggestion
E.g., SELECT ELT(2, 'scala-1', 'java-2', 'go-3') or 2.elt('scala-1',
'java-2', 'go-3') returns 'java-2'.
```
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
