pnowojski commented on code in PR #26075:
URL: https://github.com/apache/flink/pull/26075#discussion_r1939461797
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -554,6 +554,16 @@ public class ExecutionConfigOptions {
+ "all changes to downstream just
like when the mini-batch is "
+ "not enabled.");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Integer> UNBOUNDED_OVER_VERSION =
+ ConfigOptions.key("table.exec.unbounded-over.version")
+ .intType()
+ .defaultValue(1)
+ .withDescription(
+ "Which version of the unbounded over aggregation
to use: "
+ + " 1 - legacy version"
+ + " 2 - new version with improved
performance");
Review Comment:
I think we can default to version 2 indeed and keep this as an opt-out
feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]