XComp commented on code in PR #26088:
URL: https://github.com/apache/flink/pull/26088#discussion_r1940861919
##########
flink-tests/src/test/java/org/apache/flink/test/scheduling/UpdateJobResourceRequirementsITCase.java:
##########
@@ -182,6 +192,47 @@ void testManualDownScaling() throws Exception {
NUMBER_OF_SLOTS - runningTasksAfterRescale);
}
+ @Test
+ void testResourcesUnavailableAfterRescale() throws Exception {
+ final int initialRunningTasks = 3;
+ final int runningTasksAfterRescale = 2;
Review Comment:
```suggestion
final int initialRunningTasks = 4;
final int runningTasksAfterRescale = 3;
```
hm, shouldn't we go to parallelism of 3 in this case to ensure that we're
definitely needing both TaskManagers? I'm wondering whether there are test
executions where we kill one TM while the job with parallelism 2 runs on the
other TM. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
